-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mulr_rev out of forms.v #1122
mulr_rev out of forms.v #1122
Conversation
1ea61e4
to
d1d4cb8
Compare
d1d4cb8
to
3c95c57
Compare
There is certainly something smarter to do with |
@CohenCyril Since you thumbs uped the corresponding you may have an interest in this PR. Otherwise, we'll postpone to 1.0.0. |
This should ultimately be backported to mathcomp, but there is no emergency here. |
6eb8368
to
555c57c
Compare
|
Ok, it looks like the HB.instance for the |
Let's remove it then. |
I check and report asap. |
c401207
to
c889b05
Compare
classical/mathcomp_extra.v
Outdated
Structure revop X Y Z (f : Y -> X -> Z) := RevOp { | ||
fun_of_revop :> X -> Y -> Z; | ||
_ : forall x, f x =1 fun_of_revop^~ x }. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, what is this used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: try to remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed <- wrong advertisement :-/
Motivation for this change
fixes #1092
mulr_rev
had nothing to do inderive.v
Things done/to do
CHANGELOG_UNRELEASED.md
- [] added corresponding documentation in the headersCompatibility with MathComp 2.0
TODO: HB port
to make sure someone ports this PR tothe
hierarchy-builder
branch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.