helper lemmas for contra (PR #1119) #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tragicus
added
the
TODO: MC2 port
affeldt-aist
requested review from
affeldt-aist
and removed request for
affeldt-aist
affeldt-aist
approved these changes
Jan 8, 2024
|
I tentatively removed |
|
Thank you for the review and improvements. Concerning the documentation, the goal of this PR was to be able to merge before the next release, so if you plan to merge PR #1108 before then, we can also wait and update the documentation of boolp here. |
Tragicus
added a commit
to Tragicus/analysis
that referenced
this pull request
Jan 8, 2024
affeldt-aist
added a commit
to affeldt-aist/analysis
that referenced
this pull request
Jan 9, 2024
* helper lemmas for contra (PR math-comp#1119) * rm pdegen, use more PropB --------- Co-authored-by: Reynald Affeldt <[email protected]>
proux01
pushed a commit
that referenced
this pull request
Jan 9, 2024
* helper lemmas for contra (PR #1119) * rm pdegen, use more PropB --------- Co-authored-by: Reynald Affeldt <[email protected]>
proux01
removed
the
TODO: MC2 port
Tragicus
added a commit
to Tragicus/analysis
that referenced
this pull request
Jan 17, 2024
Tragicus
added a commit
to Tragicus/analysis
that referenced
this pull request
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is the (hopefully) easily mergeable subset of PR #1119.
Things done/to do
CHANGELOG_UNRELEASED.md[ ] added corresponding documentation in the headersCompatibility with MathComp 2.0
TODO: HB portto make sure someone ports this PR tothe
hierarchy-builderbranch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.