Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchy builder merged #1161

Merged
merged 216 commits into from
Jan 24, 2024

Conversation

affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Jan 22, 2024

Motivation for this change

This PR is the result of merging the branch hierarchy-builder into the master corresponding to tag 0.7.0.

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

CohenCyril and others added 30 commits March 24, 2023 16:03
Co-authored-by: Cyril Cohen <[email protected]>
Co-authored-by: Reynald Affeldt <[email protected]>
* sumeN, renaming, generalization
* quotient topology

* docs

* trying to fix build

* cleaning up proof

* more general quotients

* docs

* trying to fix build

* nitpicks

* quotType alias

* fix changelog

* fixing changelog again

---------

Co-authored-by: Reynald Affeldt <[email protected]>
* swapping machines

* proof of open map

* hausdorff accessible

* weak products equivalent

* changelog

* strengthen join_product_weak

* cleaning up proofs

* typos

* adding local notations for proof legibility

* merging product stuff

* fixing changelog

* specialized conjunctions to use less brackets and splits

* fixing grammar

* fix changelog

* fixing build

* more build fixes

---------

Co-authored-by: Reynald Affeldt <[email protected]>
- use cover in finSubCover
- use [set: ] instead of @Sett
- use shortcut notation for set comprehension
* proving sups preserve countable ent

* proof going through

* unused proofs

* linting

* metric implies countable uniformity

* fixing changelog

* linting

* metric for products

* linting

* fixing docs

* use %:pos

* fixing changelog

* fix changelog

* nitpicking

---------

Co-authored-by: Reynald Affeldt <[email protected]>
* simplifying clopen proofs

* clopen separations

* adding docs

* linting.

* nitpicks, trailing spaces, lint

---------

Co-authored-by: Reynald Affeldt <[email protected]>
* cluster1 proof

* updating changelog

* Update theories/topology.v

Co-authored-by: affeldt-aist <[email protected]>

* Update theories/topology.v

Co-authored-by: affeldt-aist <[email protected]>

* change to signature of compact_near_coveringP

* no need to name intermediate hypo

---------

Co-authored-by: affeldt-aist <[email protected]>
Co-authored-by: Reynald Affeldt <[email protected]>
* add a type for finite measures

- s-finite measures from branch kernels
- add subprobabilities
- dirac instance of probability
- rm finite_measure
- renaming
- minor fix
Co-authored-by: Quentin Vermande <[email protected]>
- a few pinfty/ninfty -> y/Ny renamings
* Add itv.v

Taking inspiration on signed.v, replacing sign by intervals.

* Add interval multiplication

* Add hints to automatically solve _ <= 1 goals

* Test to see if usable as a replacement for prob

* use notation from mathcomp_extra.v

* changelog and rm redundant code

* prefix duplicated identifiers

---------

Co-authored-by: Reynald Affeldt <[email protected]>
affeldt-aist and others added 16 commits January 9, 2024 09:12
* changelog for version 0.6.7

* upd README
* curry/uncurry of continuous functions

* compact-open topology working

* removing regular in favor of regular_space

---------

Co-authored-by: Reynald Affeldt <[email protected]>
Co-authored-by: Georges Gonthier <[email protected]>
* total variation proofs

- increasing implies BV
- splitting partitions
- right/left continuity of TV
- define variation with path
- adding monotone variation
- variation using prev and next

---------

Co-authored-by: Reynald Affeldt <[email protected]>
- to the precedeing merge remote-tracking branch
  'origin/hierarchy-builder'
@affeldt-aist
Copy link
Member Author

NB:

  • the last commit is a fix and is clearly a leftover, it would have been nicer without it but this is not a big issue
  • here are a few additions to CHANGELOG_UNRELEASED.md that are genuine
    but it is still incomplete

@proux01
Copy link
Collaborator

proux01 commented Jan 22, 2024

I guess this is just to run CI and not intended to be merged? In which case it should be a draft PR, to avoid merging it inadvertently.

@proux01
Copy link
Collaborator

proux01 commented Jan 22, 2024

* the last commit is a fix and is clearly a leftover, it would have been nicer without it but this is not a big issue

You can probably squash it into the merge commit.
Anyway, I gave it a quick look and this looks good to me.

@proux01
Copy link
Collaborator

proux01 commented Jan 22, 2024

We'll have to add 8.19 to the CI, but this can be done after merging #951

@proux01 proux01 marked this pull request as draft January 22, 2024 17:07
@affeldt-aist
Copy link
Member Author

I have completed a changelog but you'd better take a look @proux01 @CohenCyril @zstone1 .
Though it is fairly exhaustive, there certainly are technical points you'd like to explain a bit more.

It just remains to update the documentation which should be less boring and you're en route to the next release.

@proux01
Copy link
Collaborator

proux01 commented Jan 24, 2024

Honestly, I trust you here. At first glance it looks reasonable but I don't have the patience to carefully review the changelog (the remaining is ok). So as far as I'm concerned, you can push this on master.

@affeldt-aist
Copy link
Member Author

The last commit contains an update of the doc.
This is intended to be a minimal update: just to make sure that we do not mention identifiers in the headers that do not exist anymore.

If you are ok with the changelog (@proux01 seems to be) and with the doc update (that may be a good timing to add things you care about), we can do a release of MathComp-Analysis 1.0 before friday.

@affeldt-aist affeldt-aist force-pushed the hierarchy-builder_merged branch from 9be4a7e to bfcfe58 Compare January 24, 2024 14:17
@affeldt-aist affeldt-aist marked this pull request as ready for review January 24, 2024 14:17
@affeldt-aist affeldt-aist merged commit bfcfe58 into math-comp:master Jan 24, 2024
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants