Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR template #1164

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Update PR template #1164

merged 4 commits into from
Jan 25, 2024

Conversation

proux01
Copy link
Collaborator

@proux01 proux01 commented Jan 25, 2024

After move of master branch to MC2.

@proux01
Update PR template
3be05ab 
After move of master branch to MC2.
@proux01 proux01 requested a review from affeldt-aist January 25, 2024 08:54
affeldt-aist
affeldt-aist approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about suggesting the use of a temporary changelog during the life of PRs?
Also I added a link to the "how to document" wiki entry.
What do you think?

@proux01
Copy link
Collaborator Author

proux01 commented Jan 25, 2024

Ok, I let you merge at your convenience.

@affeldt-aist affeldt-aist merged commit cb51fad into math-comp:master Jan 25, 2024
3 of 24 checks passed
@proux01 proux01 deleted the update_pr_template branch January 25, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@affeldt-aist affeldt-aist affeldt-aist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proux01 @affeldt-aist