rm warnings mathcomp-2.1.0 #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affeldt-aist
added
the
enhancement ✨
affeldt-aist
force-pushed
the
warnings_20240514
branch
from
18d40aa to
496a5aa
Compare
proux01
approved these changes
May 15, 2024
Comment on lines
-1285
to
+1286
| - rewrite -bigcup_seq /=; exists `|floor (r * 2 ^+ n.+1)|%N. | ||
| - rewrite -bigcup_seq /=; exists `|reals.floor (r * 2 ^+ n.+1)|%N. |
There was a problem hiding this comment.
I guess it will require more work to avoid the duplication of floor and ceil in reals.
There was a problem hiding this comment.
I was planning to do that as a next step asap.
IshiguroYoshihiro
pushed a commit
to IshiguroYoshihiro/analysis
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This gets rid of a number of warnings that can be eliminated since we now depend on math-comp >= 2.1.0.
Checklist
CHANGELOG_UNRELEASED.md- [ ] added corresponding documentation in the headersReference: How to document
Reminder to reviewers