-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing lemmas about ereal #1264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the dual addition versions but otherwise looks good to me.
The dual lemmas have not been updated to the new naming scheme (my fault). |
I agree the latter is more readable. |
Then I'll do the renaming along this PR. |
Thanks a lot! |
Lemmas in the dual version should be aligned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few details but otherwise LGTM
Co-authored-by: Pierre Roux <[email protected]>
Co-authored-by: Pierre Roux <[email protected]>
Co-authored-by: Pierre Roux <[email protected]>
Co-authored-by: Pierre Roux <[email protected]>
Motivation for this change
just noticed a missing lemma in
constructive_ereal.v
that helps shorten a proofChecklist
CHANGELOG_UNRELEASED.md
- [ ] added corresponding documentation in the headersReference: How to document
Reminder to reviewers