Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing lemmas about ereal #1264

Merged
merged 9 commits into from
Jul 25, 2024
Merged

Conversation

affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Jul 22, 2024

Motivation for this change

just noticed a missing lemma in constructive_ereal.v that helps shorten a proof

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md

- [ ] added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Jul 22, 2024
@affeldt-aist affeldt-aist added this to the 1.3.0 milestone Jul 22, 2024
@affeldt-aist affeldt-aist requested a review from proux01 July 22, 2024 21:44
Copy link
Collaborator

@proux01 proux01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the dual addition versions but otherwise looks good to me.

@affeldt-aist
Copy link
Member Author

The dual lemmas have not been updated to the new naming scheme (my fault).
Shall we rename, say, lee_dadd to leedD or lee_dD (maybe more readable for lemmas with longer suffixes)?

@proux01
Copy link
Collaborator

proux01 commented Jul 23, 2024

I agree the latter is more readable.

@affeldt-aist
Copy link
Member Author

Then I'll do the renaming along this PR.

@proux01
Copy link
Collaborator

proux01 commented Jul 23, 2024

Thanks a lot!

@affeldt-aist
Copy link
Member Author

Lemmas in the dual version should be aligned.

Copy link
Collaborator

@proux01 proux01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few details but otherwise LGTM

CHANGELOG_UNRELEASED.md Outdated Show resolved Hide resolved
CHANGELOG_UNRELEASED.md Outdated Show resolved Hide resolved
CHANGELOG_UNRELEASED.md Outdated Show resolved Hide resolved
CHANGELOG_UNRELEASED.md Show resolved Hide resolved
@affeldt-aist affeldt-aist merged commit 899c141 into math-comp:master Jul 25, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants