Adapt to MC#1256 #1279
Merged
Adapt to MC#1256 #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tragicus
force-pushed
the
pr1256
branch
2 times, most recently
from
c9eecc1 to
94b3b7b
Compare
|
I can not see any example of that in the changelog, do we declare changing the level of a notation there? |
|
Maybe an entry in the "Changed" section is appropriate. Need this be merged ASAP? (I am just waiting for one last green light before releasing.) |
|
Making it to this release would of course be best, but it is no big deal if it waits for the next one. |
affeldt-aist
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
math-comp/math-comp#1256 changes the behavior of rewrite (seemingly because it generalizes some operations). This PR makes the necessary changes to keep compiling.
There was also a notation mismatch.
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Reminder to reviewers