to avoid a universe inconsistency with ring #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affeldt-aist
added
the
"bug" 🐛
proux01
approved these changes
Aug 8, 2024
Tragicus
approved these changes
Aug 8, 2024
|
As feared: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It is possible that MathComp-Analysis 1.3.0 is not compatible with the ring tactics
in the sense that
From mathcomp Require Import ring.triggers a universe inconsistency.(Just try to import
ringafter anything that requireswochoice.)That is not the first time that
wochoice.vcauses such a bug (#1198 (comment)).It happens that avoiding the
in3Wlemma provides a way to void the problem.(Tested on the
prob_langbranches that rely a lot ofring,field, andlra.)Hence this PR that I think should be merged asap and provided in MathComp-Analysis 1.4.0 asap.
Checklist
- [ ] added corresponding entries inCHANGELOG_UNRELEASED.md- [ ] added corresponding documentation in the headersReference: How to document
Reminder to reviewers