-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subtypes and continuous functions #1340
Conversation
3f3b7ad
to
94bf9e1
Compare
cbbb9f1
to
d77175b
Compare
I cruelly lack the expertise in HB to review this pull request. I hope @affeldt-aist will be able to add insight. From the mathematical perspective, this all seems great and potentially very useful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the changelog, maybe you are using the automatic tool to generate it but it looks like it does not handle HB definitions very well. I added very scarce documentation for the new definitions (and also spotted a few one that were not yet documented), you may want to fix/complete what I wrote. And then the usual linting.
Two related things. Now that pointed is gone from
topology
, we can canonically add topology/uniform/pseudometric onset_val
. This now just a few easy instances.Then we define a mixin for continuous functions. We build two structures from this. One is just
Continuous
for use with subtypes, andContinuousFun
for mixing with theFun
hierarchy using subspaces. And a bunch of lemmas for converting between them. Then we endow the set of continuous functions with various topologies in theArrowAsT
modules infunction_spaces.v
. In general I'd like to say "if arrow has a topology, then continuousType` inherits it, but I don't know how to say that in general, so it's fine to just manually do the instances in those modules.Checklist
CHANGELOG_UNRELEASED.md
Reference: How to document
Reminder to reviewers