Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subtypes and continuous functions #1340

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Conversation

zstone1
Copy link
Contributor

@zstone1 zstone1 commented Oct 6, 2024

Two related things. Now that pointed is gone from topology, we can canonically add topology/uniform/pseudometric on set_val. This now just a few easy instances.

Then we define a mixin for continuous functions. We build two structures from this. One is just Continuous for use with subtypes, and ContinuousFun for mixing with the Fun hierarchy using subspaces. And a bunch of lemmas for converting between them. Then we endow the set of continuous functions with various topologies in the ArrowAsT modules in function_spaces.v. In general I'd like to say "if arrow has a topology, then continuousType` inherits it, but I don't know how to say that in general, so it's fine to just manually do the instances in those modules.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@zstone1 zstone1 force-pushed the cts_mixin branch 3 times, most recently from 3f3b7ad to 94bf9e1 Compare October 10, 2024 19:41
@zstone1 zstone1 force-pushed the cts_mixin branch 3 times, most recently from cbbb9f1 to d77175b Compare October 25, 2024 21:05
@zstone1 zstone1 requested a review from affeldt-aist October 25, 2024 21:32
@mkerjean
Copy link
Collaborator

I cruelly lack the expertise in HB to review this pull request. I hope @affeldt-aist will be able to add insight. From the mathematical perspective, this all seems great and potentially very useful.

Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the changelog, maybe you are using the automatic tool to generate it but it looks like it does not handle HB definitions very well. I added very scarce documentation for the new definitions (and also spotted a few one that were not yet documented), you may want to fix/complete what I wrote. And then the usual linting.

@zstone1 zstone1 merged commit 96f4793 into math-comp:master Nov 6, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants