Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the sum topology #1368

Merged
merged 4 commits into from
Oct 29, 2024
Merged

adding the sum topology #1368

merged 4 commits into from
Oct 29, 2024

Conversation

zstone1
Copy link
Contributor

@zstone1 zstone1 commented Oct 28, 2024

Another preliminary for #1350, this adds the very basic topology for sums. There are a lot of results about sums that are missing, of course. Sums preserve uniform and pseudometric structures, and basically all the local properties. But for now I just provide what I need for homotopy theory.

Annoyingly, there is a call to the non-ssreflect tactic destruct here, when dealing with dependent equalities. When I have a fact that i = j, then form existT P i x = existT P j y should produce a x = y. I could not figure how to do this. If the destruct tactic is forbidden, then how should I remove it?

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@affeldt-aist
Copy link
Member

What is really not recommended is to let destruct figure out names itself but indeed we can do without it as shown in the last commit.

@affeldt-aist
Copy link
Member

I have a concern with the naming. Could we find another name for sum_fun? Something that shows that we are dealing with existT (since we have been using sum rather for bigops so far)? And maybe use the dsum prefix instead of sum to make clearer that this is not about the sumbool type?

@zstone1
Copy link
Contributor Author

zstone1 commented Oct 29, 2024

That is fair. Referencing it all as sigT might be the simplest, rather than mentioning sum at all.

Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo the typo in the changelog, I can't see any issue anymore.

CHANGELOG_UNRELEASED.md Outdated Show resolved Hide resolved
@zstone1 zstone1 merged commit 2634502 into math-comp:master Oct 29, 2024
19 checks passed
@t6s
Copy link
Member

t6s commented Nov 15, 2024

(sorry for commenting after merging, but)
sigT_uncurry would be a better name for sigT_fun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants