-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding the sum topology #1368
adding the sum topology #1368
Conversation
What is really not recommended is to let |
I have a concern with the naming. Could we find another name for |
That is fair. Referencing it all as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modulo the typo in the changelog, I can't see any issue anymore.
Co-authored-by: affeldt-aist <[email protected]>
(sorry for commenting after merging, but) |
Another preliminary for #1350, this adds the very basic topology for sums. There are a lot of results about sums that are missing, of course. Sums preserve uniform and pseudometric structures, and basically all the local properties. But for now I just provide what I need for homotopy theory.
Annoyingly, there is a call to the non-ssreflect tactic
destruct
here, when dealing with dependent equalities. When I have a fact thati = j
, then formexistT P i x = existT P j y
should produce ax = y
. I could not figure how to do this. If thedestruct
tactic is forbidden, then how should I remove it?Checklist
CHANGELOG_UNRELEASED.md
Reference: How to document
Reminder to reviewers