Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min and max are continuous #1387

Merged
merged 3 commits into from
Nov 10, 2024
Merged

min and max are continuous #1387

merged 3 commits into from
Nov 10, 2024

Conversation

zstone1
Copy link
Contributor

@zstone1 zstone1 commented Nov 10, 2024

Another quick, but missing, foundational topology result. The functions min, max : T * T -> T are continuous. There are a couple inelegant things about the proofs. Firstly, I end up having to case on whether x : T has an immediate successor or not. Annoying, but fine. I end up proving both min and max by hand. Ideally I'd prove one, and then the other would follow by flipping the inequalities. But there doesn't seem to be a mathcomp constructor for the "opposite" order, which is what I would need.

Neither of these annoyances should be blockers

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just performed a linting phase and gain a dozen of lines.

@zstone1 zstone1 merged commit 7e2988d into math-comp:master Nov 10, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants