Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generalize indexing in lemmas for series #1397

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

generalize indexing in lemmas for series #1397

wants to merge 2 commits into from

Conversation

t6s
Copy link
Member

@t6s t6s commented Nov 15, 2024 •
edited
Loading

Motivation for this change

There are several lemmas for series stated with zero-based indexing
0 <= k < n and n <oo.
This PR generalizes them to m <= k < n and m <= n<oo.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@t6s
Copy link
Member Author

t6s commented Nov 15, 2024

Two lemmas for orderTypes are added in mathcomp_extra.v too.

@t6s t6s requested a review from affeldt-aist November 15, 2024 01:51
affeldt-aist
affeldt-aist approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! No doubt it will be useful at some point. Just need a rebase for the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@affeldt-aist affeldt-aist affeldt-aist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t6s @affeldt-aist