Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalize the return type of RVs #1420

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

affeldt-aist
Copy link
Member

Motivation for this change

This is an uncontroversial part of the PR on sampling: it just generalizes the type of random variables. This has been made possible by the recent generalization of measurable functions defined as a type in lebesgue_measure.v.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Dec 3, 2024
@affeldt-aist affeldt-aist added this to the 1.8.0 milestone Dec 3, 2024
@affeldt-aist affeldt-aist requested a review from t6s December 3, 2024 02:29
Copy link
Member

@t6s t6s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Only thing I noticed is expectationMl could be expectationZ.

theories/probability.v Outdated Show resolved Hide resolved
@affeldt-aist affeldt-aist merged commit eee7394 into math-comp:master Dec 3, 2024
28 of 31 checks passed
@affeldt-aist affeldt-aist deleted the RV_20241203 branch December 3, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants