Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a hierarchy and a theory of kernels #896

Merged
merged 7 commits into from
May 13, 2023

Conversation

affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Apr 12, 2023

Motivation for this change

This is the "mathematical part" of PR #749 : the hierarchy of kernels and their theory (stability of s-finite kernels by composition, etc.). This is documented in https://hal.inria.fr/hal-03917948/ (which is a reviewed paper, that might
simplify the review work for this PR).

The "programming language part" of PR #749 is now in the draft PR #912 because it is still the topic of
discussion. Some parts of it might integrate master later though (e.g., kernel for scoring or for conditional branching).

(PR #749 is therefore scheduled for closing.)

@CohenCyril @AyumuSaito

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist affeldt-aist added enhancement ✨ This issue/PR is about adding new features enhancing the library TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. labels Apr 12, 2023
@affeldt-aist affeldt-aist added this to the 0.6.2 milestone Apr 12, 2023
@affeldt-aist affeldt-aist modified the milestones: 0.6.2, 0.6.3 Apr 16, 2023
@affeldt-aist affeldt-aist force-pushed the kernel_only branch 2 times, most recently from 5ecf021 to 138be1c Compare April 26, 2023 13:24
@affeldt-aist affeldt-aist requested a review from zstone1 April 27, 2023 13:16
Copy link
Contributor

@zstone1 zstone1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. The comment about an existential vs. 3 fields is the most interesting. Otherwise I don't anything too bad. I find the identical mixin + factory idiom to be a bit strange, but it's fairly common, and I can live with it.

In some sense, an empty factory with an extra condition is what you is maybe what you mean? I tried to do that with

HB.factory Record Kernel_isFinite d d' (X : measurableType d)
    (Y : measurableType d') (R : realType) (k : X -> {measure set Y -> \bar R})
    of isKernel _ _ _ _ _ k & SFiniteKernel_isFinite _ _ _ _ _ k := {
  measure_uub : measure_fam_uub k }.

However, I get

Error: I could not find classes covering exactly mixins:
[indt «SFiniteKernel_isFinite.axioms_», indt «isKernel.axioms_»]
In particular the covering [indt «FiniteKernel.axioms_»] also includes mixins:
[indt «Kernel_isSFinite_subdef.axioms_»]
This should never happen, please report a bug.

so that maybe doesn't work quite right.

theories/kernel.v Show resolved Hide resolved
theories/kernel.v Outdated Show resolved Hide resolved
theories/kernel.v Outdated Show resolved Hide resolved
theories/kernel.v Show resolved Hide resolved
theories/kernel.v Outdated Show resolved Hide resolved
theories/kernel.v Outdated Show resolved Hide resolved
theories/kernel.v Show resolved Hide resolved
theories/kernel.v Show resolved Hide resolved
Copy link
Contributor

@zstone1 zstone1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with things as they are now. Most of my issues are longer term ones about factory and mixin duplication, and R vs \bar R. They're not really complaints about this PR in particular, and I'll be happy to have this kernel stuff in master.

@affeldt-aist affeldt-aist merged commit 6d08bc0 into math-comp:master May 13, 2023
affeldt-aist added a commit that referenced this pull request May 13, 2023
* a hierarchy and a theory of kernels

Co-authored-by: Cyril Cohen <[email protected]>
Co-authored-by: @AyumuSaito
@proux01 proux01 mentioned this pull request May 15, 2023
@proux01 proux01 removed the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label May 30, 2023
IshiguroYoshihiro pushed a commit to IshiguroYoshihiro/analysis that referenced this pull request Sep 7, 2023
* a hierarchy and a theory of kernels

Co-authored-by: Cyril Cohen <[email protected]>
Co-authored-by: @AyumuSaito
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants