Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powere_pos lemmas #969

Merged
merged 2 commits into from
Jul 6, 2023
Merged

powere_pos lemmas #969

merged 2 commits into from
Jul 6, 2023

Conversation

affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Jul 6, 2023

  • refactoring by Cyril
  • also remove the .classical suffixes from Import's
  • also rename power_pos to powR
Motivation for this change

this is the part of PR #942 about power_pos,
isolated here for the sake of clarity

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist affeldt-aist added this to the 0.6.4 milestone Jul 6, 2023
@affeldt-aist affeldt-aist added TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. enhancement ✨ This issue/PR is about adding new features enhancing the library renaming/refactoring 🔧 This is about a renaming or refactoring in the library labels Jul 6, 2023
@affeldt-aist affeldt-aist mentioned this pull request Jul 6, 2023
3 tasks
@affeldt-aist
Copy link
Member Author

Most of the contents of this PR has already been reviewed by @zstone1 and @CohenCyril (now an author) so maybe this can be merged quickly? CI errors are because of the lack of adequate images or mathcomp failures due the transitional state from mathcomp 1 to mathcomp 2.

@CohenCyril CohenCyril requested a review from proux01 July 6, 2023 07:57
Copy link
Collaborator

@proux01 proux01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments. I'll merge once addressed.

theories/exp.v Outdated Show resolved Hide resolved
CHANGELOG_UNRELEASED.md Outdated Show resolved Hide resolved
CHANGELOG_UNRELEASED.md Outdated Show resolved Hide resolved
CHANGELOG_UNRELEASED.md Outdated Show resolved Hide resolved
affeldt-aist and others added 2 commits July 6, 2023 16:22
- refactoring by Cyril

Co-authored-by: Alessandro Bruni <[email protected]>
Co-authored-by: Cyril Cohen <[email protected]>
@proux01 proux01 merged commit fb9b000 into math-comp:master Jul 6, 2023
@proux01 proux01 removed the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library renaming/refactoring 🔧 This is about a renaming or refactoring in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants