Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm notation 2 in signed.v #999

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

proux01
Copy link
Collaborator

@proux01 proux01 commented Jul 31, 2023

Motivation for this change

Depends on #996 and bumps the lower bound on MathComp.

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • removed corresponding documentation in the headers
Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@proux01 proux01 added the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Jul 31, 2023
@affeldt-aist
Copy link
Member

This PR bumps the lower bound of MathComp but sill triggers the CI for MathComp 1.13 and MathComp 1.14.
Maybe we need to remove a few lines in docker-action.yml? (I am not sure about nix-action.yml.)

@proux01 proux01 force-pushed the rm_notation_2 branch 3 times, most recently from 74e83fd to 5cc3a6d Compare August 28, 2023 14:54
@proux01
Copy link
Collaborator Author

proux01 commented Aug 29, 2023

This PR bumps the lower bound of MathComp but sill triggers the CI for MathComp 1.13 and MathComp 1.14. Maybe we need to remove a few lines in docker-action.yml? (I am not sure about nix-action.yml.)

@affeldt-aist indeed, fixed, CI is now green

@proux01
Copy link
Collaborator Author

proux01 commented Sep 25, 2023

@affeldt-aist CI is green, this can be merged

@affeldt-aist affeldt-aist merged commit 8354194 into math-comp:master Sep 25, 2023
53 checks passed
@proux01 proux01 deleted the rm_notation_2 branch September 25, 2023 12:29
affeldt-aist pushed a commit to affeldt-aist/analysis that referenced this pull request Sep 27, 2023
* Remove no longer useful notation since MC 1.15

* [CI] Update Docker CI
proux01 added a commit to affeldt-aist/analysis that referenced this pull request Sep 28, 2023
* Remove no longer useful notation since MC 1.15

* [CI] Update Docker CI
proux01 added a commit that referenced this pull request Sep 28, 2023
* Remove no longer useful notation since MC 1.15

* [CI] Update Docker CI
@proux01 proux01 removed the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Sep 28, 2023
IshiguroYoshihiro pushed a commit to IshiguroYoshihiro/analysis that referenced this pull request Oct 24, 2023
* Remove no longer useful notation since MC 1.15

* [CI] Update Docker CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants