More typescript linting #3310
Merged
More typescript linting #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chguy/tslint # Conflicts: # .eslintrc.cjs # src/autodiscovery.ts # src/crypto/RoomList.ts # src/crypto/crypto.ts # src/models/MSC3089TreeSpace.ts # src/secret-storage.ts
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
andybalaam
approved these changes
Nov 21, 2024
MidhunSureshR
approved these changes
Nov 25, 2024
toger5
reviewed
Dec 2, 2024
Comment on lines
481
to
+486
| public getUserId(): string { | ||
| return this.userId; | ||
| } | ||
| public getSafeUserId(): string { | ||
| return this.userId; | ||
| } |
There was a problem hiding this comment.
Why do we need the save version of this of getUserId already returns a non optional?
What is the difference?
There was a problem hiding this comment.
This is a stub for MatrixClient, getUserId actually returns string | null
The code under test was changed to use getSafeUserId to avoid getting null and thus the test must also make this method available so it doesn't end up throwing an exception
| const localMember = this.room.getMember(this.client.getUserId()!)!; | ||
| const localMember = this.room.getMember(this.client.getSafeUserId()); |
There was a problem hiding this comment.
Here it seems to be fine to just remove the exclamation mark but keep the getUserId method?
There was a problem hiding this comment.
No, as getUserId has return type string | null in reality, the test stub is misleading
toger5
approved these changes
Dec 2, 2024
…chguy/tslint # Conflicts: # src/sync.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These linters identified a few incorrect types
This change is marked as an internal change (Task), so will not be included in the changelog.