-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jest to v29.5.4 #3670
Update jest to v29.5.4 #3670
Conversation
5952ffc
to
428e131
Compare
428e131
to
3c1732e
Compare
3c1732e
to
6627983
Compare
6627983
to
a933118
Compare
a933118
to
f034aa3
Compare
f034aa3
to
de8fd5b
Compare
de8fd5b
to
d270c08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks fine from the VoIP side
spec/unit/webrtc/groupCall.spec.ts
Outdated
afterEach(() => { | ||
groupCall.terminate(false); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given this afterEach
block, can the manual groupCall.terminate
calls below be removed?
When I attempted to run this locally, the spec/unit/interactive-auth.spec.ts test never ended, and it repeatedly logged this:
|
4d7b47f
to
f449b83
Compare
Reading the test "should fire stateUpdated callback with error when a request fails" it looks like this would always cause an infinite loop between doRequest and statusUpdated calls. I don't know why this wasn't a problem until we updated Jest to v29.5.4, but after that point it was. This change should fix the test failures for the Jest upgrade PR: #3670 .
To fix the build error here I made PR: #3722 |
Reading the test "should fire stateUpdated callback with error when a request fails" it looks like this would always cause an infinite loop between doRequest and statusUpdated calls. I don't know why this wasn't a problem until we updated Jest to v29.5.4, but after that point it was. This change should fix the test failures for the Jest upgrade PR: #3670 .
Asked for a rebase now #3722 is merged |
f449b83
to
b9aa28b
Compare
b9aa28b
to
e190e30
Compare
@andybalaam you asking for a rebase force pushed all of my changes out of the PR... 0428aa0 and parents. |
Sorry @t3chguy I had no idea you had added commits to the PR. Want me to re- add them? |
This PR contains the following updates:
29.5.3
->29.5.4
29.6.2
->29.6.4
29.6.2
->29.6.4
29.6.2
->29.6.4
29.6.2
->29.6.3
Release Notes
jestjs/jest (babel-jest)
v29.6.4
Compare Source
Fixes
[jest-core]
Fix typo inscheduleAndRun
performance marker (#14434)[jest-environment-node]
Make sureatob
andbtoa
are writeable in Node 20 (#14446)[jest-worker]
Additional error wrapper forparentPort.postMessage
to fix unhandledDataCloneError
. (#14437)v29.6.3
Compare Source
Fixes
[expect, @​jest/expect-utils]
ObjectContaining
supportsumbol
as key (#14414)[expect]
Remove@types/node
from dependencies (#14385)[jest-core]
Use workers in watch mode by default to avoid crashes (#14059 & #14085).[jest-reporters]
Updateistanbul-lib-instrument
dependency to v6. (#14401)[jest-mock]
Revert #13692 as it was a breaking change (#14429)[jest-mock]
Revert #13866 as it was a breaking change (#14429)[jest-mock]
Revert #13867 as it was a breaking change (#14429)[@jest/reporters]
Marks Reporter's hooks as optional (#14433)[jest-runtime]
Fix dynamic ESM import module bug when loaded module throughjest.isolateModulesAsync
(#14397)Chore & Maintenance
[jest-changed-files, jest-circus, jest-console, @​jest/core, @​jest/runtime, @​jest/transform]
Useinvariant
andnotEmpty
fromjest-util
rather than own internal (#14366)Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.
This change is marked as an internal change (Task), so will not be included in the changelog.