Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jest to v29.5.4 #3670

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Update jest to v29.5.4 #3670

merged 1 commit into from
Sep 12, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 23, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/jest (source) 29.5.3 -> 29.5.4 age adoption passing confidence
babel-jest 29.6.2 -> 29.6.4 age adoption passing confidence
jest (source) 29.6.2 -> 29.6.4 age adoption passing confidence
jest-environment-jsdom 29.6.2 -> 29.6.4 age adoption passing confidence
jest-mock 29.6.2 -> 29.6.3 age adoption passing confidence

Release Notes

jestjs/jest (babel-jest)

v29.6.4

Compare Source

Fixes
  • [jest-core] Fix typo in scheduleAndRun performance marker (#​14434)
  • [jest-environment-node] Make sure atob and btoa are writeable in Node 20 (#​14446)
  • [jest-worker] Additional error wrapper for parentPort.postMessage to fix unhandled DataCloneError. (#​14437)

v29.6.3

Compare Source

Fixes
  • [expect, @​jest/expect-utils] ObjectContaining support sumbol as key (#​14414)
  • [expect] Remove @types/node from dependencies (#​14385)
  • [jest-core] Use workers in watch mode by default to avoid crashes (#​14059 & #​14085).
  • [jest-reporters] Update istanbul-lib-instrument dependency to v6. (#​14401)
  • [jest-mock] Revert #​13692 as it was a breaking change (#​14429)
  • [jest-mock] Revert #​13866 as it was a breaking change (#​14429)
  • [jest-mock] Revert #​13867 as it was a breaking change (#​14429)
  • [@jest/reporters] Marks Reporter's hooks as optional (#​14433)
  • [jest-runtime] Fix dynamic ESM import module bug when loaded module through jest.isolateModulesAsync (#​14397)
Chore & Maintenance
  • [jest-changed-files, jest-circus, jest-console, @​jest/core, @​jest/runtime, @​jest/transform] Use invariant and notEmpty from jest-util rather than own internal (#​14366)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.


This change is marked as an internal change (Task), so will not be included in the changelog.

@renovate renovate bot added Dependencies Pull requests that update a dependency file T-Task Tasks for the team like planning labels Aug 23, 2023
@renovate renovate bot changed the title Update jest to v29.5.4 Update jest to v29.6.3 Aug 24, 2023
@andybalaam andybalaam marked this pull request as ready for review August 24, 2023 13:03
@andybalaam andybalaam requested a review from a team as a code owner August 24, 2023 13:03
@andybalaam andybalaam enabled auto-merge August 24, 2023 13:03
@renovate renovate bot changed the title Update jest to v29.6.3 Update jest to v29.5.4 Aug 25, 2023
@t3chguy t3chguy requested a review from a team as a code owner September 7, 2023 12:49
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine from the VoIP side

Comment on lines 1283 to 1285
afterEach(() => {
groupCall.terminate(false);
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this afterEach block, can the manual groupCall.terminate calls below be removed?

@andybalaam
Copy link
Member

When I attempted to run this locally, the spec/unit/interactive-auth.spec.ts test never ended, and it repeatedly logged this:

Cannot log after tests are done. Did you forget to wait for something async in your test?
    Attempted to log "Active flow => {"stages":["m.login.password"]}".

      46 |         /* eslint-disable no-console */
      47 |         if (supportedByConsole) {
    > 48 |             return console[methodName](...args);
         |                                       ^
      49 |         } else {
      50 |             return console.log(...args);
      51 |         }

      at console.debug (node_modules/@jest/console/build/CustomConsole.js:102:10)
      at Logger.log (src/logger.ts:48:39)
      at InteractiveAuth.chooseStage (src/interactive-auth.ts:625:16)
      at InteractiveAuth.startNextAuthStage (src/interactive-auth.ts:590:32)
      at InteractiveAuth.doRequest (src/interactive-auth.ts:553:22)
      at async InteractiveAuth.submitAuthDict (src/interactive-auth.ts:444:13)


  ●  Cannot log after tests are done. Did you forget to wait for something async in your test?
    Attempted to log "Next stage: m.login.password".

      46 |         /* eslint-disable no-console */
      47 |         if (supportedByConsole) {
    > 48 |             return console[methodName](...args);
         |                                       ^
      49 |         } else {
      50 |             return console.log(...args);
      51 |         }

      at console.debug (node_modules/@jest/console/build/CustomConsole.js:102:10)
      at Logger.log (src/logger.ts:48:39)
      at InteractiveAuth.chooseStage (src/interactive-auth.ts:627:16)
      at InteractiveAuth.startNextAuthStage (src/interactive-auth.ts:590:32)
      at InteractiveAuth.doRequest (src/interactive-auth.ts:553:22)
      at async InteractiveAuth.submitAuthDict (src/interactive-auth.ts:444:13)

@renovate renovate bot force-pushed the renovate/jest branch 2 times, most recently from 4d7b47f to f449b83 Compare September 12, 2023 11:31
andybalaam added a commit that referenced this pull request Sep 12, 2023
Reading the test "should fire stateUpdated callback with error when a
request fails" it looks like this would always cause an infinite loop
between doRequest and statusUpdated calls. I don't know why this wasn't
a problem until we updated Jest to v29.5.4, but after that point it was.

This change should fix the test failures for the Jest upgrade PR:
#3670 .
@andybalaam
Copy link
Member

To fix the build error here I made PR: #3722

github-merge-queue bot pushed a commit that referenced this pull request Sep 12, 2023
Reading the test "should fire stateUpdated callback with error when a
request fails" it looks like this would always cause an infinite loop
between doRequest and statusUpdated calls. I don't know why this wasn't
a problem until we updated Jest to v29.5.4, but after that point it was.

This change should fix the test failures for the Jest upgrade PR:
#3670 .
@andybalaam
Copy link
Member

Asked for a rebase now #3722 is merged

@t3chguy
Copy link
Member

t3chguy commented Sep 12, 2023

@andybalaam you asking for a rebase force pushed all of my changes out of the PR...

0428aa0 and parents.

image

@andybalaam
Copy link
Member

@andybalaam you asking for a rebase force pushed all of my changes out of the PR...

0428aa0 and parents.

image

Sorry @t3chguy I had no idea you had added commits to the PR. Want me to re- add them?

@andybalaam andybalaam added this pull request to the merge queue Sep 12, 2023
Merged via the queue into develop with commit 6f51747 Sep 12, 2023
24 checks passed
@andybalaam andybalaam deleted the renovate/jest branch September 12, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants