Rust: Query backup on fail to decrypt similar to libolm #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Base automatically changed from
valere/element-r/backup/restore/pr3
to
develop
September 13, 2023 13:47
andybalaam
approved these changes
Sep 14, 2023
| @@ -188,21 +149,24 @@ describe.each(Object.entries(CRYPTO_BACKENDS))("megolm-keys backup (%s)", (backe | |||
| return client; | |||
| } | |||
|
|
|||
| oldBackendOnly("Alice checks key backups when receiving a message she can't decrypt", async function () { | |||
| it("Alice checks key backups when receiving a message she can't decrypt", async function () { | |||
There was a problem hiding this comment.
I love to see tests become consistent between old and new code!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3710
Adds the capability for rust crypto to automatically make a request to backup if an event fails to decrypt due to missing key. Feature parity with legacy libolm implementation
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.