Update dependency fake-indexeddb to v6 #4224
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
added
Dependencies
dbkr
added a commit
that referenced
this pull request
May 29, 2024
dumbmatter/fakeIndexedDB#93 causes a bunch of tests to start failing because the fake timers need running in order for fake indexeddb to work. It also seems to cause failures to bleed between tests somehow if fake timers are enabled/disabled. This keeps all the fake timer tests in one suite and all the others in another, which appears to work. This should allow #4224 to be merged.
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 30, 2024
dumbmatter/fakeIndexedDB#93 causes a bunch of tests to start failing because the fake timers need running in order for fake indexeddb to work. It also seems to cause failures to bleed between tests somehow if fake timers are enabled/disabled. This keeps all the fake timer tests in one suite and all the others in another, which appears to work. This should allow #4224 to be merged.
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
ea44ea1 to
000aea0
Compare
|
Eugh, this breaks a whole bunch of our tests because anything that uses fake timers now needs to advance them for indexeddb to work. I fixed the queueToDevice ones in #4225 but now there a load more. Really feels like fake-indexeddb should have an option to pass a timer function in to bypass the fake timers or something. |
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
9289989 to
8a513f1
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
8a513f1 to
042303f
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
042303f to
f74933d
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
f74933d to
ea79fd0
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
2 times, most recently
from
80ee6bb to
e7cbbf8
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
e7cbbf8 to
1e39e62
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
1e39e62 to
2691796
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
2691796 to
c49e422
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
c49e422 to
ca94654
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
ca94654 to
c10a7ed
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
c10a7ed to
2f49f32
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
2f49f32 to
0ab9d44
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
0ab9d44 to
01ee474
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
01ee474 to
4154809
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
4154809 to
0d1da8d
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
0d1da8d to
29545b5
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
29545b5 to
0283dc1
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
0283dc1 to
4392440
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
4392440 to
65c0585
Compare
renovate
bot
force-pushed
the
renovate/fake-indexeddb-6.x
branch
from
65c0585 to
0e45b12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^5.0.2->^6.0.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
dumbmatter/fakeIndexedDB (fake-indexeddb)
v6.0.0Compare Source
I made this a new major version because it includes a few changes that could in theory break something in some weird situations. But I think the vast majority of users (possibly all users?) won't have any issue upgrading.
#48 - Switched to using
DOMExceptionerrors rather than normal errors, since that's what the IndexedDB spec says to use, and Node.js now has a built-in DOMException in all supported versions.#93 - @bryan-codaio made the latest tweak to event scheduling, this time improving how
setImmediateis used in some situations where people are mocking timers.#99 - @sjnho fixed handling of
Dateobjects to account for some edge cases, including jsdom overriding the nativeDateconstructor.Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.