feat(room): add RequestToJoinRoom subscriptions
#4338
Draft
+571
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinesp
force-pushed
the
feat/requests-to-join-listener
branch
from
5d8f036
to
f5d859b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4338 +/- ##
==========================================
- Coverage 85.08% 85.02% -0.07%
==========================================
Files 276 277 +1
Lines 30371 30488 +117
==========================================
+ Hits 25842 25921 +79
- Misses 4529 4567 +38 ☔ View full report in Codecov by Sentry. |
ganfra
reviewed
Nov 27, 2024
|
|
||
| /// Declines the request to join by banning the user from the room with an | ||
| /// optional reason. | ||
| pub async fn decline_and_ban(&self, reason: Option<String>) -> Result<(), ClientError> { |
There was a problem hiding this comment.
maybe we want a separate ban action, and let the user chain? in the case the user doesn't have the right for both
There was a problem hiding this comment.
You mean kick, then ban? Can we ban a user who already left the room?
Also, I'd expect the UI to not display the component that triggers this action rather than controlling trying to workaround the issue here.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ganfra
reviewed
Nov 27, 2024
| } | ||
|
|
||
| #[matrix_sdk_ffi_macros::export] | ||
| impl RequestToJoinActions { |
Also, add a couple of method to mark requests as seen and retrieve the current ones from the stores and update this observable field.
This struct is an abstraction over a room member or state event with knock membership.
Also add mocks for the `/members` endpoint.
jmartinesp
force-pushed
the
feat/requests-to-join-listener
branch
from
4b60abf
to
e3cd7cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: