Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drt: attempt to handle waiting time explicitly when teleporting #3095

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tschlenther
Copy link
Contributor

Attempting to explicity handle waiting time when teleporting drt (e.g. when using drt-speedup) by delaying the PassengerPickedUpEvent accodingly. The remaining problem is that TeleportingPassengerEngine delegates to the DefaultTeleportationEngine for throwing the arrival-related events like TeleportationArrivalEvent. DefaultTeleportationEngine therefore calls agent.getExpectedTravelTime().seconds(), i.e. looks up the estimated travel time in the pre-computed route (if available), which does not include the waiting time (and should not??). This then leads to the fact that the TeleportationArrivalEvent is thrown without accounting for the waiting time. Is there any smooth way out without overriding DefaultTeleportationEngine.handleDeparture @michalmac ??

@tschlenther tschlenther self-assigned this Feb 7, 2024
@tschlenther tschlenther marked this pull request as draft February 7, 2024 16:07
@michalmac
Copy link
Member

I think your approach with extending the route travel time is fine. (Not sure if that answers your question).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants