Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit Tests #110

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add Unit Tests #110

wants to merge 9 commits into from

Conversation

helloitsjoe
Copy link

@helloitsjoe helloitsjoe commented Oct 21, 2020

Hi Matt!

I noticed in your readme you want to add unit tests - I've set up Jest for canvas-sketch and added a few basic tests just to get the ball rolling. I'm happy to add more but wanted to submit a PR early in case you have any feedback.

  • Add jest
  • Set up babel to handle ES6 import syntax
  • Add unit tests for createCanvas and SketchManager

@helloitsjoe
Copy link
Author

helloitsjoe commented Nov 6, 2020

I had some time so I added a few more tests.

Also, It looks like the Netlify pipeline isn't passing because it's still on Node 8, but Jest 26/27 require Node 10 or above. I would downgrade to Jest 24, but it doesn't play as nicely with the canvas package (and also Node 8 is no longer supported)

@alvinometric alvinometric self-assigned this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants