This repository has been archived by the owner on Jun 28, 2018. It is now read-only.
Add oracle oci8 driver #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll need to add oracle to the docker-compose.yml for testing perhaps? |
|
Thanks for implementing! Would you be interested in porting this to the latest v3? |
|
Would you mind changing the target branch to v1 ? |
|
Hey @mattes, I've changed the base branch to v1. As for porting to v3, it's very possible and I probably will in the future, but probably won't be able to for now (busy). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the driver interface for oci8 using mattn's go-oci8 oracle driver.