Text edits which have the same start position are reversed

[kyoh86]

In LSP spec, an order of the text-edits which have the same start position should be applied in order of them.
Neovim LSP client was applied them in reversed order, but it's fixed in neovim/neovim#29202.
So now, formatting some continuous lines with efm-langserver, text lines are reversed.
Please see the issue neovim/neovim#29392 for steps to reproduce and details.

[kyoh86]

In the golang/tools, the ComputeEdits is being used only as testing util....
https://github.com/golang/tools/blob/d9c6af3f039a6193d1557d780752f223b3978173/internal/diff/myers/diff.go

[kyoh86]

It is deprecated in the golang/tools.
I think it would be better to re-implement using google/go-cmp or something similar.

[kyoh86]

The reason for the deprecated status was not related to this project, so I think that we can continue to use the ComputeEdits as it is.

[kyoh86]

#282 (comment)

I had neglected to mention that this change would affect other clients as well.
At a minimum I would check for the following clients

• vim-lsp
• coc.nvim
• Eglot
• Helix
• VSCode

Since it will take time to verify all environments, we will withdraw the request and ask for another review after the investigation.

If anybody could help me for testing them, give me your help.

[conao3]

I will try to check this issue using Eglot.

[kyoh86]

📝 I finished testing for vim-lsp, helix and coc.nvim.

[conao3]

I checked Eglot. It worked the same way as vim-lsp.

[konradmalik]

I believe that the TL;DR of this is that the fix recently introduced in neovim was not a fix, but a regression in fact.
This PR reverted the previous change, added more tests and fixed the behavior: neovim/neovim#29877

[kyoh86]

yes, it has fixed in Neovim!