Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: put continuous insertions with the same line in order of applying #282

Closed
wants to merge 3 commits into from

Conversation

kyoh86
Copy link
Contributor

@kyoh86 kyoh86 commented Jul 13, 2024

fix: #281

@mattn
Copy link
Owner

mattn commented Jul 13, 2024

Thank you. Does this problem only occur with neovim?

@kyoh86
Copy link
Contributor Author

kyoh86 commented Jul 13, 2024

I'll check it in vim.

@kyoh86
Copy link
Contributor Author

kyoh86 commented Jul 13, 2024

@mattn
I confirmed that the issue #281 is a problem that occurs only in Neovim.
However, Neovim contributors have stated that this is the result of a fix in accordance with the LSP specification, and as a result, the fix in efm-langserver is reasonable.

When we merge this pull request, I seem to have a problem like #281 with vim+vim-lsp this time.
Perhaps the vim-lsp implementation needs to be modified as well...

@kyoh86
Copy link
Contributor Author

kyoh86 commented Jul 14, 2024

@mattn
I had neglected to mention that this change would affect other clients as well.
At a minimum I would check for the following clients

  • vim-lsp
  • coc.nvim
  • Eglot
  • Helix
  • VSCode

Since it will take time to verify all environments, we will withdraw the request and ask for another review after the investigation.
Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text edits which have the same start position are reversed
2 participants