System test stabilization

maybe-finance · May 30, 2024 · c96e32d · c96e32d
1 parent 5c29d95
commit c96e32d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
@@ -28,8 +28,6 @@ def notification(text, **options, &block)
   #     <div>Content here</div>
   #   <% end %>
   #
-  # @note can also be triggered via ?modal=model&entity_id=uuid query params
-  #
   def modal(options = {}, &block)
     content = capture &block
     render partial: "shared/modal", locals: { content:, classes: options[:classes] }
@@ -43,7 +41,6 @@ def modal(options = {}, &block)
   #     <div>Content here</div>
   #   <% end %>
   #
-  # @note can also be triggered via ?drawer=model&entity_id=uuid query params
   def drawer(&block)
     content = capture &block
     render partial: "shared/drawer", locals: { content: content }

diff --git a/test/application_system_test_case.rb b/test/application_system_test_case.rb
@@ -2,7 +2,7 @@
 
 class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
   setup do
-    Capybara.default_max_wait_time = 8
+    Capybara.default_max_wait_time = 5
   end
 
   driven_by :selenium, using: ENV["CI"].present? ? :headless_chrome : :chrome, screen_size: [ 1400, 1400 ]

diff --git a/test/system/transactions_test.rb b/test/system/transactions_test.rb
@@ -53,6 +53,8 @@ class TransactionsTest < ApplicationSystemTestCase
       fill_in "Search transactions by name", with: @target_txn.name
     end
 
+    assert_selector "#" + dom_id(@target_txn), count: 1
+
     find("#transaction-filters-button").click
 
     within "#transaction-filters-menu" do