Merge pull request #35 from MichaelDeBoey/remove-convertKit-usage

feat: remove ConvertKit usage

.env.example

@@ -22,4 +22,3 @@ AWS_SESSION_TOKEN=
 NX_PLAID_SECRET=
 NX_FINICITY_APP_KEY=
 NX_FINICITY_PARTNER_SECRET=
-NX_CONVERTKIT_SECRET=

.github/workflows/validate-pull-request.yml

@@ -75,7 +75,6 @@ jobs:
                   NX_STRIPE_SECRET_KEY=${{ secrets.NX_STRIPE_SECRET_KEY }}
                   NX_STRIPE_WEBHOOK_SECRET=${{ secrets.NX_STRIPE_WEBHOOK_SECRET }}
                   NX_PLAID_WEBHOOK_URL=none
-                  NX_CONVERTKIT_SECRET=none
                   NX_DATABASE_URL=postgresql://maybe:maybe@localhost:5432/maybe_local?connection_limit=32&pool_timeout=20
                   NX_REDIS_URL=redis://localhost:6379
                   EOF

apps/server/src/app/app.ts

@@ -42,7 +42,6 @@ import {
     securitiesRouter,
     plansRouter,
     toolsRouter,
-    notificationsRouter,
     publicRouter,
     e2eRouter,
 } from './routes'
@@ -167,7 +166,6 @@ app.use('/v1/transactions', transactionsRouter)
 app.use('/v1/holdings', holdingsRouter)
 app.use('/v1/securities', securitiesRouter)
 app.use('/v1/plans', plansRouter)
-app.use('/v1/notifications', notificationsRouter)
 
 // Sentry must be the *first* handler
 app.use(identifySentryUser)

apps/server/src/app/lib/endpoint.ts

@@ -55,7 +55,6 @@ import prisma from './prisma'
 import plaid, { getPlaidWebhookUrl } from './plaid'
 import finicity, { getFinicityTxPushUrl, getFinicityWebhookUrl } from './finicity'
 import stripe from './stripe'
-import convertKit from './convertKit'
 import postmark from './postmark'
 import { managementClient } from './auth0'
 import s3 from './s3'
@@ -315,7 +314,6 @@ export async function createContext(req: Request) {
         prisma,
         plaid,
         stripe,
-        convertKit,
         s3,
         secretsClient,
         managementClient,

apps/server/src/app/routes/index.ts

@@ -13,6 +13,5 @@ export { default as holdingsRouter } from './holdings.router'
 export { default as securitiesRouter } from './securities.router'
 export { default as plansRouter } from './plans.router'
 export { default as toolsRouter } from './tools.router'
-export { default as notificationsRouter } from './notifications.router'
 export { default as publicRouter } from './public.router'
 export { default as e2eRouter } from './e2e.router'

apps/server/src/env.ts

@@ -79,7 +79,6 @@ const envSchema = z.object({
     // Key to Cloudfront pub key
     NX_CDN_SIGNER_PUBKEY_ID: z.string().default('REPLACE_THIS'),
 
-    NX_CONVERTKIT_SECRET: z.string(),
     NX_POSTMARK_FROM_ADDRESS: z.string().default('[email protected]'),
     NX_POSTMARK_REPLY_TO_ADDRESS: z.string().default('[email protected]'),
     NX_POSTMARK_API_TOKEN: z.string().default('REPLACE_THIS'),

aws/maybe-app/lib/stacks/server-stack.ts

@@ -197,24 +197,6 @@ export class ServerStack extends Stack {
                         }
                     )
                 ),
-                NX_CONVERTKIT_KEY: ECSSecret.fromSsmParameter(
-                    StringParameter.fromSecureStringParameterAttributes(
-                        this,
-                        'ConvertKitKeyParam',
-                        {
-                            parameterName: '/providers/NX_CONVERTKIT_KEY',
-                        }
-                    )
-                ),
-                NX_CONVERTKIT_SECRET: ECSSecret.fromSsmParameter(
-                    StringParameter.fromSecureStringParameterAttributes(
-                        this,
-                        'ConvertKitSecretParam',
-                        {
-                            parameterName: '/providers/NX_CONVERTKIT_SECRET',
-                        }
-                    )
-                ),
                 NX_POSTMARK_API_TOKEN: ECSSecret.fromSsmParameter(
                     StringParameter.fromSecureStringParameterAttributes(
                         this,

libs/client/shared/src/api/index.ts

@@ -9,4 +9,3 @@ export * from './useTransactionApi'
 export * from './useHoldingApi'
 export * from './useSecurityApi'
 export * from './usePlanApi'
-export * from './useNotificationsApi'

libs/shared/src/types/user-types.ts

@@ -295,23 +295,3 @@ export interface LinkConfig {
 export type PublicTokenExchange = LinkConfig & {
     institution: Institution
 }
-
-/**
- * ================================================================
- * ======                 ConvertKitApi                      ======
- * ================================================================
- */
-
-export type ConvertKitSubscriber = {
-    id: number
-    first_name: string
-    email_address: string
-    state: 'cancelled' | 'active'
-    created_at: string
-}
-
-export type ConvertKitSubscription = {
-    id: number
-    state: 'cancelled' | 'active'
-    subscriber: Pick<ConvertKitSubscriber, 'id'>
-}

prisma/schema.prisma

@@ -409,9 +409,6 @@ model User {
 
   isoCurrencyCode String @default("USD") @map("iso_currency_code")
 
-  // Notification preferences
-  convertKitId Int? @map("convert_kit_id")
-
   // Financial preferences and info
   monthlyIncomeUser   Decimal? @map("monthly_income_user") @db.Decimal(19, 4)
   monthlyExpensesUser Decimal? @map("monthly_expenses_user") @db.Decimal(19, 4)