Allow users to set preferred locale in settings and provide basic date and time localization support #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…users-to-configure-their-locale-and-provide-a-default-date-format-based-on-locale
zachgoll
deleted the
909-allow-users-to-configure-their-locale-and-provide-a-default-date-format-based-on-locale
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #1225 , we will be supporting currency, date, and time localization in the near-term for a variety of locales.
The approach I have taken in this PR is incremental adoption of various locales.
I have set the
config.i18n.fallbacks = trueso that all missing keys fall back to the default locale, which isen. This will allow for an incremental adoption of I18n and will allow users to start setting up their preferred locale and get some immediate improvements rather than waiting for an "all or nothing" change.All locale translations come directly from the official
rails-i18nrepo as suggested in the docs.