Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for customized synth URL from env variable #1490

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

Evlos
Copy link
Contributor

@Evlos Evlos commented Nov 22, 2024

Usage:

---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: maybe
spec:
  template:
    spec:
      containers:
      - name: maybe
        image: evlos/maybe:latest
        env:
        - name: SYNTH_URL
          value: http://192.168.233.107:30800

@zachgoll
Copy link
Collaborator

Hey @Evlos, can you explain this change a bit further? I'm guessing your use case here involves some sort of incoming traffic proxy?

Typically, we only accept contributions that would apply to a broad range of users but want to make sure I understand this better first.

@Evlos
Copy link
Contributor Author

Evlos commented Nov 23, 2024

Hello @zachgoll, yes, this is related to the incoming traffic proxy.

I find that maybe needs to frequently access online resources. I live in a remote mountainous area where the cellular signal is often unstable, so the maybe page can’t load at times, which is quite frustrating for me. I believe there are many people in the world living in areas with poor network conditions. Using an incoming traffic proxy to cache data and read from the cache when the network has issues, instead of waiting endlessly for the network to recover, would allow me to use the self-hosted maybe service.

Additionally, this approach can also save server resources for synthfinance.com.

You are doing a great job. I hope the above meets your requirements for accepting contributions.

@zachgoll
Copy link
Collaborator

@Evlos thanks for the explanation! That makes sense. We definitely want to provide support for various regions like this.

@zachgoll zachgoll merged commit 570a0c7 into maybe-finance:main Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants