Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: Loan % doesn't allow exact rate #1492

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

arsenstorm
Copy link
Contributor

Fixes #1487

Change the step of the interest rate field to 0.005.

It's unlikely that we'll see interest rates in smaller increments.

Fixes maybe-finance#1487

Change the step of the interest rate field to 0.005.

It's unlikely that we'll see interest rates in smaller increments.
@arsenstorm arsenstorm marked this pull request as draft November 22, 2024 18:28
@arsenstorm arsenstorm marked this pull request as ready for review November 22, 2024 18:49
Copy link
Collaborator

@zachgoll zachgoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this seems like a reasonable limit to use.

@zachgoll zachgoll merged commit 1c2f075 into maybe-finance:main Nov 22, 2024
5 checks passed
@ahatzz11
Copy link
Contributor

Thanks!

@arsenstorm arsenstorm deleted the fix-loan-rate-bug branch November 22, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Loan % Doesn't allow exact Rate
3 participants