Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced Native Scrollbars with Tailwind Scrollbars on Windows #1493

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Replaced Native Scrollbars with Tailwind Scrollbars on Windows #1493

merged 2 commits into from
Nov 22, 2024

Conversation

jestinjoshi
Copy link
Contributor

Continuing from #1439

Changes Made:

  • Added a new detect_os function in application_controller.rb
  • The detected OS will be added as a class to the html tag
  • Based on the added class, the scrollbar styling will be applied (can be scaled to other OS if required)

zachgoll
zachgoll approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@zachgoll zachgoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple, I like it!

@zachgoll zachgoll merged commit 571fc4d into maybe-finance:main Nov 22, 2024
5 checks passed
@jestinjoshi
Copy link
Contributor Author

Nice and simple, I like it!

Thank you! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachgoll zachgoll zachgoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jestinjoshi @zachgoll