Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plaid sync tests and multi-currency investment support #1531

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

zachgoll
Copy link
Collaborator

@zachgoll zachgoll commented Dec 12, 2024

Closes #1087

This PR enables multi-currency investment accounts along with several other investment-related improvements:

  • Splits the Plaid investment sync into PlaidInvestmentSync as the logic required is quite extensive due to all the edge cases
  • Adds basic Plaid sync testing with some test data helpers
  • Adds a sample data migration for cleaning up cash holdings in the prod DB

@zachgoll zachgoll marked this pull request as ready for review December 12, 2024 13:42
@zachgoll zachgoll merged commit 800eb4c into main Dec 12, 2024
5 checks passed
@zachgoll zachgoll deleted the zachgoll/multi-currency-investments branch December 12, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support multi-currency syncing for Investment account portfolios
1 participant