-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial pass at Plaid EU #1555
Draft
Shpigford
wants to merge
6
commits into
main
Choose a base branch
from
plaid-eu
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Initial pass at Plaid EU #1555
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
de78d56
Initial pass at Plaid EU
Shpigford 0c9cb33
Add EU support to Plaid Items
Shpigford 867620b
Merge branch 'main' into plaid-eu
Shpigford de3e2e1
Lint
Shpigford 8541abd
Merge branch 'plaid-eu' of https://github.com/maybe-finance/maybe int…
Shpigford 37ca549
Temp fix for rubocop isseus
Shpigford File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,9 @@ | ||
class PlaidItem < ApplicationRecord | ||
include Plaidable, Syncable | ||
|
||
enum :plaid_region, { us: "us", eu: "eu" } | ||
validates :plaid_region, inclusion: { in: plaid_regions.keys } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
|
||
if Rails.application.credentials.active_record_encryption.present? | ||
encrypts :access_token, deterministic: true | ||
end | ||
|
@@ -56,10 +59,11 @@ def destroy_later | |
private | ||
def fetch_and_load_plaid_data | ||
data = {} | ||
item = plaid_provider.get_item(access_token).item | ||
provider = plaid_provider_for(self) | ||
item = provider.get_item(access_token).item | ||
update!(available_products: item.available_products, billed_products: item.billed_products) | ||
|
||
fetched_accounts = plaid_provider.get_item_accounts(self).accounts | ||
fetched_accounts = provider.get_item_accounts(self).accounts | ||
data[:accounts] = fetched_accounts || [] | ||
|
||
internal_plaid_accounts = fetched_accounts.map do |account| | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,18 @@ | ||
Rails.application.configure do | ||
config.plaid = nil | ||
config.plaid_eu = nil | ||
|
||
if ENV["PLAID_CLIENT_ID"].present? && ENV["PLAID_SECRET"].present? | ||
config.plaid = Plaid::Configuration.new | ||
config.plaid.server_index = Plaid::Configuration::Environment[ENV["PLAID_ENV"] || "sandbox"] | ||
config.plaid.api_key["PLAID-CLIENT-ID"] = ENV["PLAID_CLIENT_ID"] | ||
config.plaid.api_key["PLAID-SECRET"] = ENV["PLAID_SECRET"] | ||
end | ||
|
||
if ENV["PLAID_EU_CLIENT_ID"].present? && ENV["PLAID_EU_SECRET"].present? | ||
config.plaid_eu = Plaid::Configuration.new | ||
config.plaid_eu.server_index = Plaid::Configuration::Environment[ENV["PLAID_ENV"] || "sandbox"] | ||
config.plaid_eu.api_key["PLAID-CLIENT-ID"] = ENV["PLAID_EU_CLIENT_ID"] | ||
config.plaid_eu.api_key["PLAID-SECRET"] = ENV["PLAID_EU_SECRET"] | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
class AddRegionToPlaidItem < ActiveRecord::Migration[7.2] | ||
def change | ||
add_column :plaid_items, :plaid_region, :string, null: false, default: "us" | ||
end | ||
end |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
create_from_public_token
method onPlaidItem
will need to be updated to accept this param