Preserve original transaction names when enriching #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgoll
commented
Dec 19, 2024
| WHEN 'Account::Valuation' THEN 'Balance update' | ||
| ELSE 'Unknown entry' | ||
| END | ||
| WHERE name IS NULL |
There was a problem hiding this comment.
only updating "bad data" that currently exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of data quality updates in this PR:
namerequired onAccount::Entry- since users are able to directly edit this value, enforcing non-nullability makes sense and prevents data quality errors that have come up recentlyenriched_namerather than overwritingname. This will allow us to preserve "rollback" abilities in the future if a user wants to revert (or just see) the original txn name before enrichment was applied (increase user confidence in enabling the enrichment feature)