Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic devcontainer #247

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

robzolkos
Copy link
Contributor

@robzolkos robzolkos commented Feb 2, 2024

Makes it easier for developers to open the project and have all of its dependencies work consistently.

All that is required is a docker development environment (Docker + VS Code + DevContainers extension is the most common).

@robzolkos robzolkos marked this pull request as draft February 2, 2024 16:17
@robzolkos
Copy link
Contributor Author

Waiting on #248 and a green CI to move forward.

@robzolkos robzolkos marked this pull request as ready for review February 2, 2024 16:26
These are scaffolded placeholder tests anyway.  Once reale features are
added the skips will be removed.
@robzolkos
Copy link
Contributor Author

robzolkos commented Feb 2, 2024

@Shpigford once this is merged, let me know if your local dev environment still works (assume you don't use a devcontainer). If it doesn't lets work out what the differences are to make it work and then I'll update the readme for both kinds of workflow (non-docker and docker).

@Shpigford Shpigford merged commit 253ae29 into maybe-finance:main Feb 2, 2024
4 checks passed
@robzolkos
Copy link
Contributor Author

bundle (as there was gems updated in previous PRs merged)

@Shpigford
Copy link
Member

@robzolkos Merged and successfully running bin/dev.

I've got zero experience with devcontainers, so if there's some other workflow to use at this point, let me know. 🙂

@robzolkos
Copy link
Contributor Author

All good. If it works without devcontainers you can continue on as normal, I'll add a piece into the readme for collaborators that prefer to use devcontainers.

@JoshAntBrown
Copy link
Contributor

JoshAntBrown commented Feb 2, 2024

Interestingly, my setup uses brew to install and manage Postgres and for some reason doesn't have the default superuser postgres. Instead, it uses the system login name. So the change to the database config to explicitly use this user breaks on my machine.

Happy to add the user to my database, but might be something others run into when trying to get started. Any thoughts @Shpigford @robzolkos?

@robzolkos
Copy link
Contributor Author

Yeah thought this may be the case. Will pr a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants