-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic devcontainer #247
Conversation
Waiting on #248 and a green CI to move forward. |
These are scaffolded placeholder tests anyway. Once reale features are added the skips will be removed.
80fd0b6
to
d6291b6
Compare
@Shpigford once this is merged, let me know if your local dev environment still works (assume you don't use a devcontainer). If it doesn't lets work out what the differences are to make it work and then I'll update the readme for both kinds of workflow (non-docker and docker). |
|
@robzolkos Merged and successfully running I've got zero experience with devcontainers, so if there's some other workflow to use at this point, let me know. 🙂 |
All good. If it works without devcontainers you can continue on as normal, I'll add a piece into the readme for collaborators that prefer to use devcontainers. |
Interestingly, my setup uses brew to install and manage Postgres and for some reason doesn't have the default superuser Happy to add the user to my database, but might be something others run into when trying to get started. Any thoughts @Shpigford @robzolkos? |
Yeah thought this may be the case. Will pr a fix |
Makes it easier for developers to open the project and have all of its dependencies work consistently.
All that is required is a docker development environment (Docker + VS Code + DevContainers extension is the most common).