Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to set port in env #726

Merged
merged 5 commits into from
May 8, 2024
Merged

Allow users to set port in env #726

merged 5 commits into from
May 8, 2024

Conversation

claudey
Copy link
Contributor

@claudey claudey commented May 8, 2024

Users can set a custom PORT variable in .env if 300 is used by other other apps.

Solves #565

maybe-allow-users-to-set-port.mov

zachgoll
zachgoll reviewed May 8, 2024
View reviewed changes
Copy link
Collaborator

@zachgoll zachgoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

bin/dev Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@claudey claudey requested a review from zachgoll May 8, 2024 19:34
@zachgoll zachgoll merged commit d240c59 into maybe-finance:main May 8, 2024
4 checks passed
@claudey claudey mentioned this pull request May 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachgoll zachgoll zachgoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claudey @zachgoll