Reusable CI workflow for GH actions #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgoll
commented
May 30, 2024
|
|
||
| - name: System tests | ||
| run: DISABLE_PARALLELIZATION=true bin/rails test:system | ||
| continue-on-error: true # TODO: Eventually we'll enforce for PRs |
There was a problem hiding this comment.
As explained in #817, the intention here is to allow for us to start running system tests during the CI process without enforcing them yet. We'll eventually remove this and require system tests once the app reaches a more stable point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small consolidation of duplicate workflows so we're running the same CI process for PRs and merges to main.