Add bulk selection UI controls #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
zachgoll
commented
Jun 6, 2024
| <div class="col-span-2 ml-auto"> | ||
| <%= render "transactions/amount", transaction: transaction %> | ||
| </div> | ||
| <% end %> |
There was a problem hiding this comment.
As the global transactions UI is getting a lot more complex with bulk selection and inline editing, I decided to make the transaction rows in the account view read-only for the time being.
Eventually we'll probably want to mirror some of the functionality implemented in the global view here, but trying to manage this in two spots adds unnecessary complexity right now.
zachgoll
commented
Jun 6, 2024
| @@ -43,7 +43,9 @@ | |||
|
|
|||
| resources :transactions do | |||
| collection do | |||
| match "search" => "transactions#search", via: %i[ get post ] | |||
There was a problem hiding this comment.
stale route that I missed earlier in the transactions cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a Stimulus controller to handle bulk selection of transactions (although the controller is generic to any collection of records).
CleanShot.2024-06-07.at.12.41.03.mp4
Future PRs will handle the bulk edit and delete operations.