fix: #842 - "undefined" value on dashboard assets graph #844
Conversation
|
@AurelienConte do you plan to continue work on this? No worries either way, just let me know! |
|
Sorry i was on vacation, I just come back today at work ! |
|
@AurelienConte sounds great! |
…return also how the symbol should be displayed
|
I made changes to the feat, if you think this is good to you i will start modifying my tests to match the code changes |
@zachgoll did you find any time to check my work ? |
…e dashboard pie chart
| entire_text = value_element.find(:xpath, '..').text # Get full text of the <p> element | ||
| extracted_value = entire_text.strip.gsub(/[^\d.]/, '').sub(/^0+/, '') # Removing non-digit characters except the decimal point | ||
| assert_equal expected_value, extracted_value, "The pie chart value is not displayed correctly" | ||
| end |
There was a problem hiding this comment.
I think we should test this functionality in a new system test called test/system/dashboard_test.rb, and for now, we can have a single test:
class DashboardTest < ApplicationSystemTestCase
test "displays pie chart" do
# click on assets
# assert formatted value
# click on debts
# assert formatted value
end
end
|
Perfect, I'll start testing when I have some time |
|
@zachgoll sorry but i think i can not find enough time to finish this ... can you finish this for me ? |
|
@AurelienConte yep, I can finish it up! Thanks for letting me know. |
|
Going to close this out for now and will circle back when I finish some of the investment work I'm doing. |
Fixing issue of
FractionalPartdisplaying "undefined" in the pie chart element used to display assets and debts on the dashboardEDIT : Please, do not hesitate to tell me about the testing part, i'm not familiar with ruby and tools in this ecosystem. I'm still learning and maybe i used them in a not proper way !