Read input registers and basic support of little Indian values #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Last minute bug fix on some little Indian values.. |
|
Many thanks for contributing @PhilippeRigaux! Can you please check the output from the linter workflow and rename indianess/indian to endianness/endian? |
|
I saw that you didn't managed the multi-bytes value in your initial code so I added it to big endian too. |
|
What is the "linter workflow"? |
You can run |
|
OK, saw the emails, currently fixing them..
… Le 28 févr. 2024 à 10:51, Marcus Zoller ***@***.***> a écrit :
What is the "linter workflow"?
You can run make check-code to run the linter. The linter is blocking a merge if there are code formatting issues. It's a bit picky but helps to ensure readability...
—
Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEDPZ2NVUDB3JZ6XUIT2ET3YV4D2HAVCNFSM6AAAAABD44TA52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRYG4ZDCMZXGQ>.
You are receiving this because you were mentioned.
|
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support Solax X1 G4 inverters, one need to decode little Indian numbers and read Input registers. Sample config file included..