Async on_transition() #29
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-otiv
commented
Oct 23, 2024
andrew-otiv
commented
Oct 23, 2024
delete unnecessary comments
andrew-otiv
commented
Oct 23, 2024
There was a problem hiding this comment.
Diff looks good to me. Tests are passing locally, but there is no new test coverage. New example coverage covers both the macro and the no-macro case.
Let us know if you have a CLA or other steps to get this upstreamed @mdeloof!
|
Converted back to a draft because we have lifetime issues using it in our codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work by @wvhulle and me to get on_transition() working with async.