-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect available output sample formats, translate samples. #54
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 47.00% 46.60% -0.40%
==========================================
Files 23 23
Lines 1368 1384 +16
==========================================
+ Hits 643 645 +2
- Misses 725 739 +14 ☔ View full report in Codecov by Sentry. |
It seems this fixes the problem by skipping the problematic entry/ies.
Is this a cpal problem? |
I think you're right. I just added the |
Device sample formats are now autodetected and song samples are translated into the appropriate format for these devices. This should make MacOS support easier, since it looks like many of the devices there only support the float output format.
445b13e
to
d271040
Compare
If I switch the system default speaker to the dongle I get:
Otherwise:
|
That is bizarre. So cpal doesn't report any available outputs there, it seems -- I'm not totally sure what I can do in this situation, unfortunately. Do you have any other apps open that might be interfering? |
It's a problem with cpal. There is even a merge request open since september last year: I added some output form the cpal example enumerate. Thanks! |
Device sample formats are now autodetected and song samples are translated into the appropriate format for these devices. This should make MacOS support easier, since it looks like many of the devices there only support the float output format.
Closes #51