Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Optimize Loads on Queries #4220

Conversation

michael-genson
Copy link
Collaborator

What type of PR is this?

(REQUIRED)

  • cleanup

What this PR does / why we need it:

(REQUIRED)

This adds more loads to our Pydantic models to make queries more efficient. A lot of models proxy the household_id from other parent models, so we pre-join them to make fewer database queries.

Which issue(s) this PR fixes:

(REQUIRED)

Closes #4084

@github-actions github-actions bot added the chore label Sep 16, 2024
@michael-genson michael-genson merged commit ba363da into mealie-recipes:mealie-next Sep 20, 2024
13 checks passed
@michael-genson michael-genson deleted the chore/optimize-joined-loads branch September 20, 2024 04:10
boc-the-git pushed a commit to boc-the-git/mealie that referenced this pull request Sep 28, 2024
boc-the-git pushed a commit to boc-the-git/mealie that referenced this pull request Sep 28, 2024
Choromanski pushed a commit to Choromanski/mealie that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] - Optimize joinedload On Pydantic Models
2 participants