Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Shopping list UI overhaul - add label headings per category #4235

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

Wetzel402
Copy link
Contributor

What type of PR is this?

  • feature

What this PR does / why we need it:

  • Each label now has it's own add button
    image

Which issue(s) this PR fixes:

#4077

Testing

Tested in dev container

	modified:   frontend/pages/shopping-lists/_id.vue
Copy link
Collaborator

@Kuchenpirat Kuchenpirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few little things on this one.

Thanks for your work so far! When everything finally rolls into mealie this will certainly improve the shopping list 😊

frontend/pages/shopping-lists/_id.vue Outdated Show resolved Hide resolved
@Kuchenpirat Kuchenpirat self-assigned this Sep 19, 2024
@Kuchenpirat
Copy link
Collaborator

Let's use "#959595" as default label color. This would be a compromise and should be readable on both light and dark mode

	modified:   frontend/pages/shopping-lists/_id.vue
	modified:   mealie/schema/labels/multi_purpose_label.py
@Wetzel402
Copy link
Contributor Author

I just realized when VS Code did an autoformat it caused a lot of changes in github.

Copy link
Collaborator

@Kuchenpirat Kuchenpirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good 👍

@Kuchenpirat Kuchenpirat merged commit 04dc593 into mealie-recipes:mealie-next Sep 24, 2024
13 checks passed
@Wetzel402 Wetzel402 deleted the labels branch September 26, 2024 21:02
boc-the-git pushed a commit to boc-the-git/mealie that referenced this pull request Sep 28, 2024
boc-the-git pushed a commit to boc-the-git/mealie that referenced this pull request Sep 28, 2024
Choromanski pushed a commit to Choromanski/mealie that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants