Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update makederiv #299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update makederiv #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions makederiv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ if [[ "${OUTPUT_TYPE}" == "broadcast" ]] ; then
if [[ "${ADDSLATE}" = "Y" ]]; then
SUFFIX="_SLATE"
fi
if [[ "${TCBURN}" = "Y" ]]; then
SUFFIX="_TC"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one would override the previous SLATE one. We should use SUFFIX+="_TC"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would require an unset SUFFIX before the suffix has the potential to be evaluated so we don't have a loop of "_TC_TC_TC" when multiple files are processed in one action.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also if you move the if then TC to go after the if statement that contains it then it would only need to be said once rather than multiple times.

fi
elif [[ "${OUTPUT_TYPE}" == "broadcast_copy" ]] ; then
EXTENSION="mov"
RELATIVEPATH=""
Expand All @@ -108,10 +111,16 @@ elif [[ "${OUTPUT_TYPE}" == "prores" ]] ; then
EXTENSION="mov"
RELATIVEPATH="objects/access/prores"
USEACCESSTIMES="Y"
if [[ "${TCBURN}" = "Y" ]]; then
SUFFIX="_TC"
fi
elif [[ "${OUTPUT_TYPE}" == "youtube" ]] ; then
EXTENSION="mp4"
RELATIVEPATH="objects/access/youtube_up"
USEACCESSTIMES="Y"
if [[ "${TCBURN}" = "Y" ]]; then
SUFFIX="_TC"
fi
elif [[ "${OUTPUT_TYPE}" == "resourcespace" ]] ; then
PREFERRED_SOURCE="service"
EXTENSION="mp4"
Expand Down