Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export Comparator and LexicographicComparator traits #218

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Re-export Comparator and LexicographicComparator traits #218

merged 1 commit into from
Nov 7, 2023

Conversation

xiaoyawei
Copy link
Contributor

@xiaoyawei xiaoyawei commented Nov 7, 2023 •
edited
Loading

Pull Request

Related issue

A minor followup on #212

What does this PR do?

  • Reexport 2 traits such that it'll be easier to use them; now I have to explicitly include heed-traits in my Cargo.toml

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Kerollmops I forgot this in my last PR, and didn't realize this until I started to use the new version of heed just now, haha

@xiaoyawei xiaoyawei changed the title re-export some traits Re-export Comparator and LexicographicComparator traits Nov 7, 2023
Kerollmops
Kerollmops approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that small fix. Merging!

I will publish a new release today, in a couple hours.

@Kerollmops Kerollmops merged commit fa73d82 into meilisearch:main Nov 7, 2023
8 checks passed
@xiaoyawei xiaoyawei deleted the export_some_traits branch November 7, 2023 09:07
@xiaoyawei xiaoyawei restored the export_some_traits branch November 7, 2023 09:07
@xiaoyawei xiaoyawei deleted the export_some_traits branch November 7, 2023 09:07
@Kerollmops
Copy link
Member

The v0.20.0-alpha.6 is now available on crates.io 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoyawei @Kerollmops