Improve the Rw*Iter::put_current methods to be less restrictive
#222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
force-pushed
the
put-current-with-data-codec
branch
from
2824585 to
512cf2b
Compare
Kerollmops
changed the title
Rw*Iter::put_current methods to be less restrictive
Kerollmops
force-pushed
the
put-current-with-data-codec
branch
from
388b8ed to
0d93f97
Compare
irevoire
approved these changes
Nov 23, 2023
Kerollmops
force-pushed
the
put-current-with-data-codec
branch
from
0d93f97 to
d362eb0
Compare
Kerollmops
force-pushed
the
put-current-with-data-codec
branch
from
d362eb0 to
44ebdd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we rename the
Rw*Iter::put_current_with_flagsfunctions intoRw*Iter::put_current_with_optionsand make it possible to change the data codec simultaneously. This way, we do not introduce a newput_currentfunction that cannot accept LMDBPutFlags.We also modify the
Rw*Iter::put_current_reservedinto aRw*Iter::put_current_reserved_with_flagsto make it possible to specify other flags at the same time as using the "reserved" API interface.