Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing unittest setup calls #2550

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

zas
Copy link
Collaborator

@zas zas commented Nov 6, 2024

I reviewed the code and checked all setUp() and tearDown() definitions, some were missing parent method call, and some were useless.

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

Solution

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

Related to #2547

@zas zas requested a review from phw November 6, 2024 09:18
@phw phw enabled auto-merge (rebase) November 6, 2024 09:21
@phw phw merged commit 154aab5 into metabrainz:master Nov 6, 2024
44 checks passed
@zas zas deleted the add_missing_unittest_setup_calls branch November 6, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants