Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 E2E: Run multiple BMO upgrade tests in sequence #1561

Merged
merged 1 commit into from
Apr 10, 2024
Merged

🌱 E2E: Run multiple BMO upgrade tests in sequence #1561

merged 1 commit into from
Apr 10, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Feb 20, 2024

This PR will run multiple BMO upgrade tests from multiple BMO versions (kustomizations), in sequence.

The log tree for the upgrade set was also modified to be more identifiable.

test/e2e/_artifacts/                                                                                                                                                                                                                                                                                                                                                                                                                                                                                       
├── bmo-upgrade-from-e2e-release-0-3                                                                                                                                                                                                                                                                                                                                                                                                                                                                       
│   ├── logs                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               
│   │   ├── bmo-from-e2e-release-0-3                                                                                                                                                                                                                                                                                                                                                                                                                                                                       
│   │   │   └── baremetal-operator-controller-manager                                                                                                                                                                                                                                                                                                                                                                                                                                                      
│   │   │       ├── baremetal-operator-controller-manager-696c96dbdc-lr9vc                                                                                                                                                                                                                                                                                                                                                                                                                                 
│   │   │       │   ├── kube-rbac-proxy-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                  
│   │   │       │   ├── kube-rbac-proxy.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                
│   │   │       │   ├── manager-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                          
│   │   │       │   └── manager.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                        
│   │   │       ├── baremetal-operator-controller-manager-6d8c55778b-8lk2h                                                                                                                                                                                                                                                                                                                                                                                                                                 
│   │   │       │   ├── kube-rbac-proxy-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                  
│   │   │       │   ├── kube-rbac-proxy.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                
│   │   │       │   ├── manager-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                          
│   │   │       │   └── manager.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                        
│   │   │       ├── baremetal-operator-controller-manager-7dd8b7c4b4-slg8g                                                                                                                                                                                                                                                                                                                                                                                                                                 
│   │   │       │   ├── kube-rbac-proxy-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                  
│   │   │       │   ├── kube-rbac-proxy.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                
│   │   │       │   ├── manager-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                          
│   │   │       │   └── manager.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                        
│   │   │       ├── baremetal-operator-controller-manager-7dd8b7c4b4-t9g5l                                                                                                                                                                                                                                                                                                                                                                                                                                 
│   │   │       │   ├── kube-rbac-proxy-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                  
│   │   │       │   ├── kube-rbac-proxy.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                
│   │   │       │   ├── manager-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                          
│   │   │       │   └── manager.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                        
│   │   │       ├── baremetal-operator-controller-manager-7dd8b7c4b4-vxn6g                                                                                                                                                                                                                                                                                                                                                                                                                                 
│   │   │       │   ├── kube-rbac-proxy-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                  
│   │   │       │   ├── kube-rbac-proxy.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                
│   │   │       │   ├── manager-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                          
│   │   │       │   └── manager.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                        
│   │   │       └── baremetal-operator-controller-manager-896c6d5b9-78gtq                                                                                                                                                                                                                                                                                                                                                                                                                                  
│   │   │           ├── kube-rbac-proxy-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                  
│   │   │           ├── kube-rbac-proxy.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                
│   │   │           ├── manager-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                          
│   │   │           └── manager.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                        
│   │   ├── bmo-upgrade-main                                                                                                                                                                                                                                                                                                                                                                                                                                                                               
│   │   │   └── baremetal-operator-controller-manager                                                                                                                                                                                                                                                                                                                                                                                                                                                      
│   │   │       ├── baremetal-operator-controller-manager-696c96dbdc-lr9vc                                                                                                                                                                                                                                                                                                                                                                                                                                 
│   │   │       │   ├── kube-rbac-proxy-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                  
│   │   │       │   ├── kube-rbac-proxy.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                
│   │   │       │   ├── manager-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                          
│   │   │       │   └── manager.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                        
│   │   │       ├── baremetal-operator-controller-manager-6d8c55778b-8lk2h                                                                                                                                                                                                                                                                                                                                                                                                                                 
│   │   │       │   ├── kube-rbac-proxy-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                  
│   │   │       │   ├── kube-rbac-proxy.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                
│   │   │       │   ├── manager-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                          
│   │   │       │   └── manager.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                        
│   │   │       ├── baremetal-operator-controller-manager-7dd8b7c4b4-slg8g                                                                                                                                                                                                                                                                                                                                                                                                                                 
│   │   │       │   ├── kube-rbac-proxy-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                  
│   │   │       │   ├── kube-rbac-proxy.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                
│   │   │       │   ├── manager-log-metadata.json                                                                                                                                                                                                                                                                                                                                                                                                                                                          
│   │   │       │   └── manager.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                        
│   │   │       ├── baremetal-operator-controller-manager-7dd8b7c4b4-t9g5l                                                                                                                                                                                                                                                                             
│   │   │       │   ├── kube-rbac-proxy-log-metadata.json                                                                                                                                                                                                                                                                                              
│   │   │       │   ├── kube-rbac-proxy.log                                                                                                                                                                                                                                                                                                            
│   │   │       │   ├── manager-log-metadata.json                                                                                                                                                                                                                                                                                                      
│   │   │       │   └── manager.log                                                                                                                                                                                                                                                                                                                    
│   │   │       ├── baremetal-operator-controller-manager-7dd8b7c4b4-vxn6g                                                                                                                                                                                                                                                                             
│   │   │       │   ├── kube-rbac-proxy-log-metadata.json                                                                                                                                                                                                                                                                                              
│   │   │       │   ├── kube-rbac-proxy.log                                                                                                                                                                                                                                                                                                            
│   │   │       │   ├── manager-log-metadata.json                                                                                                                                                                                                                                                                                                      
│   │   │       │   └── manager.log                                                                                                                                                                                                                                                                                                                    
│   │   │       └── baremetal-operator-controller-manager-896c6d5b9-78gtq                                                                                                                                                                                                                                                                              
│   │   │           ├── kube-rbac-proxy-log-metadata.json                                                                                                                                                                                                                                                                                              
│   │   │           ├── kube-rbac-proxy.log                                                                                                                                                                                                                                                                                                            
│   │   │           ├── manager-log-metadata.json                                                                                                                                                                                                                                                                                                      
│   │   │           └── manager.log                                                                                                                                                                                                                                                                                                                    
│   │   └── ironic                                                                                                                                                                                                                                                                                                                                     
│   │       └── ironic                                                                                                                                                                                                                                                                                                                                 
│   │           ├── ironic-76997c6c6-cflm5                                                                                                                                                                                                                                                                                                             
│   │           │   ├── ironic-httpd-log-metadata.json                                                                                                                                                                                                                                                                                                 
│   │           │   ├── ironic-httpd.log                                                                                                                                                                                                                                                                                                               
│   │           │   ├── ironic-inspector-log-metadata.json                                                                                                                                                                                                                                                                                             
│   │           │   ├── ironic-inspector.log                                                                                                                                                                                                                                                                                                           
│   │           │   ├── ironic-log-metadata.json                                                                                                                                                                                                                                                                                                       
│   │           │   ├── ironic-log-watch-log-metadata.json                                                                                                                                                                                                                                                                                             
│   │           │   ├── ironic-log-watch.log                                                                                                                               
│   │           │   └── ironic.log                                                                                                                                         
│   │           ├── ironic-76997c6c6-s4qbk                                                                                                                                 
│   │           │   ├── ironic-httpd-log-metadata.json                                                                                                                     
│   │           │   ├── ironic-httpd.log                                                                                                                                   
│   │           │   ├── ironic-inspector-log-metadata.json                                                                                                                 
│   │           │   ├── ironic-inspector.log                                                                                                                               
│   │           │   ├── ironic-log-metadata.json                                                                                                                           
│   │           │   ├── ironic-log-watch-log-metadata.json                                                                                                                 
│   │           │   ├── ironic-log-watch.log                                                                                                                               
│   │           │   └── ironic.log                                                                                                                                         
│   │           └── ironic-76997c6c6-vv27n                                                                                                                                 
│   │               ├── ironic-httpd-log-metadata.json                                                                                                                     
│   │               ├── ironic-httpd.log                                                                                                                                   
│   │               ├── ironic-inspector-log-metadata.json                                                                                                                 
│   │               ├── ironic-inspector.log                                                                                                                               
│   │               ├── ironic-log-metadata.json                                                                                                                           
│   │               ├── ironic-log-watch-log-metadata.json                                                                                                                 
│   │               ├── ironic-log-watch.log                                                                                                                               
│   │               └── ironic.log                                                                                                                                         
│   └── resources                                                                                                                                                          
│       └── upgrade-v6bm0w                                                                                                                                                 
│           └── events.log                                                                                                                                                 
├── bmo-upgrade-from-e2e-release-0-4                                         
....

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 20, 2024
@mquhuy mquhuy force-pushed the mquhuy/run-multiple-bmo-upgrades branch 2 times, most recently from a789ca7 to fb53d36 Compare February 20, 2024 14:19
@mquhuy
Copy link
Member Author

mquhuy commented Feb 20, 2024

/test metal3-bmo-e2e-test-pull
/test metal3-bmo-e2e-test-optional-pull

@mquhuy mquhuy mentioned this pull request Feb 21, 2024
Merged
@mquhuy mquhuy marked this pull request as draft February 29, 2024 08:04
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 29, 2024
@mquhuy mquhuy force-pushed the mquhuy/run-multiple-bmo-upgrades branch 8 times, most recently from a0cf589 to 1c35b02 Compare March 4, 2024 06:23
@mquhuy
Copy link
Member Author

mquhuy commented Mar 4, 2024

/test metal3-bmo-e2e-test-pull
/test metal3-bmo-e2e-test-optional-pull

@mquhuy
Copy link
Member Author

mquhuy commented Mar 4, 2024

/retest

@mquhuy mquhuy marked this pull request as ready for review March 4, 2024 06:38
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Mar 4, 2024

/test metal3-bmo-e2e-test-pull
/test metal3-bmo-e2e-test-optional-pull

1 similar comment
@mquhuy
Copy link
Member Author

mquhuy commented Mar 4, 2024

/test metal3-bmo-e2e-test-pull
/test metal3-bmo-e2e-test-optional-pull

@mquhuy
Copy link
Member Author

mquhuy commented Mar 4, 2024

/test metal3-bmo-e2e-test-pull

4 similar comments
@mquhuy
Copy link
Member Author

mquhuy commented Mar 4, 2024

/test metal3-bmo-e2e-test-pull

@lentzi90
Copy link
Member

lentzi90 commented Mar 4, 2024

/test metal3-bmo-e2e-test-pull

@lentzi90
Copy link
Member

lentzi90 commented Mar 4, 2024

/test metal3-bmo-e2e-test-pull

@lentzi90
Copy link
Member

lentzi90 commented Mar 4, 2024

/test metal3-bmo-e2e-test-pull

@mquhuy
Copy link
Member Author

mquhuy commented Mar 4, 2024

/test metal3-bmo-e2e-test-optional-pull

lentzi90
lentzi90 reviewed Mar 4, 2024
View reviewed changes
test/e2e/config/fixture.yaml Outdated Show resolved Hide resolved
test/e2e/upgrade_test.go Show resolved Hide resolved
test/e2e/upgrade_test.go Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/run-multiple-bmo-upgrades branch from 1c35b02 to 5fbae42 Compare March 5, 2024 09:12
@metal3-io-bot metal3-io-bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 5, 2024
lentzi90
lentzi90 reviewed Apr 5, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
I think this is almost ready to merge but would like to see some better documentation/comments first.

I also want to suggest that you consider if we should actually include Ironic at this point. Why not make this a BMO upgrade only? It is possible that we later discover some issue or want to do things in a different way for Ironic. Coupling them together in the same upgrade spec like this will make these things harder to fix later.

test/e2e/e2e_config.go Outdated Show resolved Hide resolved
test/e2e/upgrade_test.go Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/run-multiple-bmo-upgrades branch 3 times, most recently from f2c22e4 to b878a9a Compare April 5, 2024 13:05
@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 5, 2024
@mquhuy mquhuy force-pushed the mquhuy/run-multiple-bmo-upgrades branch from b878a9a to 841553e Compare April 5, 2024 13:06
@mquhuy
Copy link
Member Author

mquhuy commented Apr 5, 2024

/test ?

@metal3-io-bot
Copy link
Contributor

@mquhuy: The following commands are available to trigger required jobs:

  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test metal3-bmo-e2e-test-pull
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-bmo-e2e-test-optional-pull
  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-keep-clusterctl-upgrade-test-main
  • /test metal3-keep-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-keep-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-keep-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main
  • /test metal3-ubuntu-e2e-integration-test-main

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gomod
  • manifestlint
  • shellcheck
  • test
  • unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mquhuy
Copy link
Member Author

mquhuy commented Apr 5, 2024

/test metal3-bmo-e2e-test-optional-pull
/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

@mquhuy mquhuy requested a review from lentzi90 April 5, 2024 13:09
lentzi90
lentzi90 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this now!
/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Apr 8, 2024

/cc @kashifest @tuminoid @Rozzii

tuminoid
tuminoid reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit.

ironic-deployment/overlays/e2e-with-inspector/kustomization.yaml Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/run-multiple-bmo-upgrades branch from 841553e to 0cdb997 Compare April 9, 2024 07:08
@mquhuy
Copy link
Member Author

mquhuy commented Apr 9, 2024

/test metal3-bmo-e2e-test-optional-pull
/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

tuminoid
tuminoid reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit.

@mquhuy mquhuy force-pushed the mquhuy/run-multiple-bmo-upgrades branch from 0cdb997 to fa5fe56 Compare April 10, 2024 08:31
@mquhuy
Copy link
Member Author

mquhuy commented Apr 10, 2024

/test metal3-bmo-e2e-test-optional-pull
/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

tuminoid
tuminoid reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@metal3-io-bot metal3-io-bot merged commit 36f134e into metal3-io:main Apr 10, 2024
20 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/run-multiple-bmo-upgrades branch April 10, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@lentzi90 lentzi90 lentzi90 approved these changes

@kashifest kashifest Awaiting requested review from kashifest

@Rozzii Rozzii Awaiting requested review from Rozzii

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mquhuy @lentzi90 @metal3-io-bot @tuminoid